-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add instructions for profiling with Superluminal #11496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| ~~~~~~~~~~~~ | ||
|
|
||
| Superluminal is a commercial profiler with many features and a special focus on game development. | ||
| It has support for profiling on Windows, Xbox One® and Xbox Series X®, PlayStation® 4 and PlayStation® 5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| It has support for profiling on Windows, Xbox One® and Xbox Series X®, PlayStation® 4 and PlayStation® 5. | |
| It has support for profiling on Windows, Xbox One, Xbox Series X, PlayStation 4, and PlayStation 5. |
We don't use the trademark symbol elsewhere and it doesn't make much sense to use it here I'd say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, since Godot itself does not officially support consoles, it may not be worth listing console platforms here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Maybe I can add "some console platforms" for completeness? I think it's relevant even if consoles are not officially supported, because you can (in some ways) port for consoles.
| - `VerySleepy <http://www.codersnotes.com/sleepy/>`__ (Windows only) | ||
| - `HotSpot <https://github.com/KDAB/hotspot>`__ (Linux only) | ||
| - `Xcode Instruments <https://developer.apple.com/xcode/>`__ (macOS only) | ||
| - `Superluminal <https://superluminal.eu/>`__ (Windows, Xbox, and PlayStation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should list this under "recommended profilers" as it isn't free
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to keep in the same list for conciseness' sake, but I would add a mention that it's paid:
| - `Superluminal <https://superluminal.eu/>`__ (Windows, Xbox, and PlayStation) | |
| - `Superluminal <https://superluminal.eu/>`__ (Windows, Xbox, and PlayStation, requires paid license) |
|
FYI, this is going to conflict with #11484 which moves the content of this page to another page. Shouldn't be too bad, though, for either of us to rebase (depending on which is merged first), since you're just adding a new section |
I'm fine rebasing this after. It should be easy to plug it somewhere else. |
4e867c2 to
f7865f5
Compare
No description provided.